<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://reviewboard.kde.org/r/4903/">http://reviewboard.kde.org/r/4903/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Great patch. Thanks for the feedback!</pre>
<br />
<p>- Artur</p>
<br />
<p>On August 4th, 2010, 5:58 p.m., Aaron Seigo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Artur de Souza (MoRpHeUz).</div>
<div>By Aaron Seigo.</div>
<p style="color: grey;"><i>Updated 2010-08-04 17:58:07</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this patch set:
* changes the layout of the sources in the engine; it introduces a Mimetypes entry for all mimetypes, and populates all the plugins at the start
* reacts to changes in ksycoca (one down side: it is brute force, it just removes all sources and starts over; would be more graceful to just add new ones, remove old ones?)
* installs the backend .desktop files
* cleans up some of the services files added</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/kdereview/plasma/dataengines/share/backends/imagebinca/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/imageshack/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/imgur/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/pastebinca/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/pastebincom/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/simplestimagehosting/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/wklej/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/backends/wstaw/CMakeLists.txt <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/plasma-dataengine-share.desktop <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/plasma_shareprovider.desktop <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/shareengine.h <span style="color: grey">(1159195)</span></li>
<li>/trunk/kdereview/plasma/dataengines/share/shareengine.cpp <span style="color: grey">(1159195)</span></li>
</ul>
<p><a href="http://reviewboard.kde.org/r/4903/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>