Review Request: battery: change brightness on mouse wheel
Alex Fiestas
alex at eyeos.org
Sun Aug 1 17:48:22 CEST 2010
On 08/01/2010 03:53 AM, Aaron Seigo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4810/#review6758
> -----------------------------------------------------------
>
>
> you don't need to propagate wheel events (or most other events, for that matter, unless there is an underlying implementation that also needs to be called). i don't know why it would be crashing with looking at the backtrace.
>
> that said, however, i don't see the connection between the battery icon and the brightness of the screen. screen brightness affects power usage, sure, but it's a little like scrolling on the app menu and having it switch between windows :)
>
> as such, i don't think this is something that should go into svn.
>
> - Aaron
jeeje, you told me exactly that when I sent you almost the same patch a
year ago.
More information about the Plasma-devel
mailing list