Review Request: Close notification with middle click

[Martin Gräßlin]

> On 2010-04-24 19:59:00, Aaron Seigo wrote:
> > maybe we should make it possible to close any window by middle clicking on it so you don't have to click the small close button. ;) i really don't like these kinds of magic behaviours as there is no feedback to the user that the action they are about to undertake will have such an effect. it's very cool that you've implemented this based on a user request, but i don't think it's the kind of request that we should seriously consider fulfilling due to its impact on the conistency and trustability of the overall UI.

That concern is true, but I think it's kind of consistent. E.g. it is used in tabbox to close a window. It's also possible to be used in present windows to close a window by middle click, but there it is configurable. I thought about exactly that issue and about adding a config option to it, but I think it is overkill. It is a hidden feature, you normally don't middle click a notification or an entry in the tabbox. So the chance to do harm - especially for notifications - is rather low. On the other hand what do you want to achieve if you click a notification? Probably saying "hey I read that, go away!".


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3802/#review5211
-----------------------------------------------------------


On 2010-04-24 19:17:46, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3802/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 19:17:46)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Adding functionality to close a notifcation when clicking anywhere on the notification with a middle click. This makes it easier to close the notification as you do not have to hit the tiny close button.
> 
> I was asked by a user to add this feature :-)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h 1117624 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp 1117624 
> 
> Diff: http://reviewboard.kde.org/r/3802/diff
> 
> 
> Testing
> -------
> 
> Tested with knotify passivepopup: middle clicking on the notification closes it both as a standalone notification and in the notification browser.
> 
> 
> Thanks,
> 
> Martin
> 
>