Review Request: Close notification with middle click

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3802/#review5211
-----------------------------------------------------------


maybe we should make it possible to close any window by middle clicking on it so you don't have to click the small close button. ;) i really don't like these kinds of magic behaviours as there is no feedback to the user that the action they are about to undertake will have such an effect. it's very cool that you've implemented this based on a user request, but i don't think it's the kind of request that we should seriously consider fulfilling due to its impact on the conistency and trustability of the overall UI.

- Aaron


On 2010-04-24 19:17:46, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3802/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 19:17:46)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> Adding functionality to close a notifcation when clicking anywhere on the notification with a middle click. This makes it easier to close the notification as you do not have to hit the tiny close button.
> 
> I was asked by a user to add this feature :-)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.h 1117624 
>   trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp 1117624 
> 
> Diff: http://reviewboard.kde.org/r/3802/diff
> 
> 
> Testing
> -------
> 
> Tested with knotify passivepopup: middle clicking on the notification closes it both as a standalone notification and in the notification browser.
> 
> 
> Thanks,
> 
> Martin
> 
>