Review Request: basic activity manager

[Chani Armitage]

> On 2010-04-23 16:33:26, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp, lines 312-314
> > <http://reviewboard.kde.org/r/3780/diff/1/?file=24331#file24331line312>
> >
> >     does the activity manager really need to care if we don't have a containment? we can get the corona by other means.

I think it mattered for positioning the window properly... either that or it's an artifact of the widgetexplorer


> On 2010-04-23 16:33:26, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h, lines 123-131
> > <http://reviewboard.kde.org/r/3780/diff/1/?file=24335#file24335line123>
> >
> >     i'm on the fence as to whether these belong in PlasmaApp or not. for now, it's ok, i think. but if we end up with more complex (or just "more") code related to activity management in plasma-desktop, then we're probably going to want to split it out into its own class.
> >     
> >     for now, let's just see where this takes us.

ahh. yeah, I asked if it belonged in plasmaapp or desktopcorona iirc, and you didn't say anything, so I just started adding to plasmaapp.

we *are* going to end up with more codde; this is the bare minimum for whats implenented so far. I also think i'll end up with a class representing a single activity, it'll make things easier


> On 2010-04-23 16:33:26, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp, line 471
> > <http://reviewboard.kde.org/r/3780/diff/1/?file=24336#file24336line471>
> >
> >     again, not sure we want containments really associated too much with the activity manager. it should be fully self-contained and not need to know which containment it is associated with.
> >     
> >     in the case where it is embedded in an existing ControllerWindow (e.g. panel toolbox -> activities), we already have one so we know where to show it and which orientation it should take.
> >     
> >     in the case where it is being called up directly via PlasmaApp::showActivityManager, i think it should just always be at the bottom of the screen as a horizontal strip. which means we don't need a containment.
> >     
> >     the corona can be gotten from PlasmaApp.

hmm.

I'll look into that next then, see how many contaimnent assumptions aree in the code


- Chani


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3780/#review5187
-----------------------------------------------------------


On 2010-04-22 21:06:15, Chani Armitage wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3780/
> -----------------------------------------------------------
> 
> (Updated 2010-04-22 21:06:15)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is the beginning of the activity manager.
> it's not very pretty yet; it doesn't have many features yet; but it's a start.
> switching between activities and creating new ones works.
> 
> at the moment "activities" are still just containments; soon this will use the proper activity API instead.
> 
> stuff that's not implemented yet:
> -responding to signals for anything other than added activities
> -showing a pretty thumbnail for each activity
> -start/stop/remove buttons
> -filtering
> 
> 
> Diffs
> -----
> 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /dev/null PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/CMakeLists.txt 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.h 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/controllerwindow.cpp 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.h 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/desktopview.cpp 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/panelcontroller.cpp 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.h 1115355 
>   /trunk/KDE/kdebase/workspace/plasma/desktop/shell/plasmaapp.cpp 1115355 
> 
> Diff: http://reviewboard.kde.org/r/3780/diff
> 
> 
> Testing
> -------
> 
> known issues:
> -removing a containment seems to crash ControllerWindow, because the destructor tries to use the containment's corona. I'm wondering if there's a way to fix this other than having ActivityManager store a pointer to the corona... of course it wouldn't be a problem if we could delete things off the scene without removing them first :/
> -if you make the activitymanager or widgetexplorer go away without clicking the close button, its geometry is wrong the next time it's shown. not sure what's up with that.
> 
> 
> Thanks,
> 
> Chani
> 
>