Review Request: Implemented Plasma::GaussianBlur effect
rich at kde.org
Tue Apr 20 18:29:56 CEST 2010
On Tue, Apr 20, 2010 at 4:49 PM, Aaron Seigo <aseigo at kde.org> wrote:
>> On 2010-04-20 15:18:25, Richard Moore wrote:
>> > Missing d pointer
>> > When not move the function that allocates the gauss vector into the private object?
> it isn't a public class (none of the animations are), so a dptr isn't actually needed in this case :)
It looked to me as if the intention was to have a reusable BlurEffect
that was a public QGraphicsEffect, with the animation merely using it.
If so then that would need the effect class to be public. Obviously if
the only user is the animation then my comments don't apply.
More information about the Plasma-devel