Review Request: Implemented Plasma::GaussianBlur effect

[Aaron Seigo]

> On 2010-04-20 15:18:25, Richard Moore wrote:
> > Missing d pointer
> > When not move the function that allocates the gauss vector into the private object?
> >

it isn't a public class (none of the animations are), so a dptr isn't actually needed in this case :)


- Aaron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3672/#review5119
-----------------------------------------------------------


On 2010-04-20 15:07:52, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3672/
> -----------------------------------------------------------
> 
> (Updated 2010-04-20 15:07:52)
> 
> 
> Review request for Plasma, Aaron Seigo, Marco Martin, igorto, and Adenilson Cavalcanti.
> 
> 
> Summary
> -------
> 
> Implemented the Plasma::GaussianBlurEffect effect, which subclasses from Qt's QGraphicsEffect and provides an alternative blur effect to the default (exponential blur). This effect is also animation-friendly (i.e. by altering the alpha value).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/CMakeLists.txt 1116913 
>   trunk/KDE/kdelibs/plasma/private/effects/gaussianblur.cpp PRE-CREATION 
>   trunk/KDE/kdelibs/plasma/private/effects/gaussianblur_p.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/3672/diff
> 
> 
> Testing
> -------
> 
> An implementation of the Plasma::BlurAnimation, which can make use of both this class and Qt's QGraphicsBlurEffect animation is available, along with the required modifications on the Animation example plasmoid, which seemed to work just fine :-)
> 
> 
> Thanks,
> 
> Bruno
> 
>