Review Request: monochrome battery in panel

Marco Martin notmart at gmail.com
Tue Apr 13 20:49:30 CEST 2010


On Tuesday 13 April 2010, Sebastian Kügler wrote:
> On Monday, April 12, 2010 22:52:23 nuno pinheiro wrote:
> > A Segunda, 12 de Abril de 2010 18:14:21 Marco Martin você escreveu:
> > > -----------------------------------------------------------
> > > http://reviewboard.kde.org/r/3574/
> > > -----------------------------------------------------------
> > > 
> > > this makes the battery load a different svg in the panel, a monochrome
> > > one, to match with the systray oriented theme it's being building. when
> > > it's in the desktop and in the popup is still the default svg
> > 
> > me likes need to find some time to review those icons but overal I like
> > it
> 
> I like it, too. Please commit.
> 
> As to the theme itself, I'm not sure though if white is the best foreground
> colour for the notification area icons, though. Using the Theme's
> foreground colour gives us more contrast, which right now comes mainly
> from the shadows, the white on top of the panel doesn't have a lot of
> contrast.

i share the concerns over contrast, i did them as it was decided a while ago. 
i tried to make them dark and looked rather terrible (maybe nuno can do 
something that looks better eheh :))

Cheers,
Marco Martin


More information about the Plasma-devel mailing list