Aaron J. Seigo aseigo at
Fri Apr 9 00:57:10 CEST 2010

On April 8, 2010, Anton Kreuzkamp wrote:
> I would appreciate it if you could review it and possibly integrate it into
> Trunk. Thanks.

looks good. two comments on it:

* context.query() is already trim()'d, so you don't have to re-trim() them.

* in reloadConfiguration, the runner should create one or more QuerySyntax 
objects and register them with addSyntax or setSyntaxes.

other than that, if you'd like to maintain this in KDE's svn, that'd be cool. 
you'll need an svn account[1] and commit to maintaining the plugin. it would 
go into kdeplasma-addons/runners.


Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks

More information about the Plasma-devel mailing list