Review Request: add "Open Image" action to slideshow wallpaper context menu

Aaron Seigo aseigo at kde.org
Tue Apr 6 19:41:28 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3498/#review4898
-----------------------------------------------------------

Ship it!


it's good for me, with one small change to the user visible text. bonus points for the fixes to the coding style. :)


trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp
<http://reviewboard.kde.org/r/3498/#comment4378>

    for consistency with the above action, it sould probably be "Open Wallpaper Image".


- Aaron


On 2010-04-06 17:40:53, Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3498/
> -----------------------------------------------------------
> 
> (Updated 2010-04-06 17:40:53)
> 
> 
> Review request for Plasma and Chani Armitage.
> 
> 
> Summary
> -------
> 
> I use slideshow mode for my wallpaper and occasionally an image appears that needs to be rotated, but I don't know where the file is.  I added a context action to slideshow wallpaper that will open the current image in the image app the user has configured (gwenview by default I believe) so it can then be rotated/fixed whatever.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1109045 
>   trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp 1109045 
> 
> Diff: http://reviewboard.kde.org/r/3498/diff
> 
> 
> Testing
> -------
> 
> I tested it on my machine that has trunk built and it seems to work fine.
> 
> 
> Thanks,
> 
> Jeremy
> 
>



More information about the Plasma-devel mailing list