Review Request: Do not use values() over a QHash when it's not really necessary

Albert Astals Cid aacid at kde.org
Sun Apr 4 12:48:42 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3490/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Calling values and then foreach on a QHash is slower and more memory intensive than just foreach the QHash, this changes the first to the second.


Diffs
-----

  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1110839 

Diff: http://reviewboard.kde.org/r/3490/diff


Testing
-------

It compiles


Thanks,

Albert



More information about the Plasma-devel mailing list