Review Request: contextmenu on popupapplets

Chani chanika at
Tue Sep 29 02:42:23 CEST 2009

This is an automatically generated e-mail. To reply, visit:

Review request for Plasma.


when I rightclick a popupapplet, I expect to get a contextmenu, but it doesn't happen because the event reaches Plasma::Dialog and stops.
with this code, popupapplet grabs the event and makes sure it gets through. :) since everything is handled by Containment (there is no Applet::contextMenuEvent) I bypass the usual checks (they'd just break things anyways since it's not a qgraphicssceneevent) with a new function in Containment.
I'm wondreing if I should make that new function protected or private, though, and make popupapplet a friend.

there are still some big dead areas on kickoff and device notifier that just eat clicks; maybe I'll fix that too at some point.


  /trunk/KDE/kdelibs/plasma/containment.h 1027322 
  /trunk/KDE/kdelibs/plasma/containment.cpp 1027322 
  /trunk/KDE/kdelibs/plasma/popupapplet.cpp 1027322 



works on panel and desktop.



More information about the Plasma-devel mailing list