Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/#review2415
-----------------------------------------------------------

Ship it!


to me the patch it's fine (and the webbrowser plasmoid should definitly use that), aaron are there still issues that are pushing it back?

- Marco


On 2009-09-22 10:30:38, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1094/
> -----------------------------------------------------------
> 
> (Updated 2009-09-22 10:30:38)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1025780 
>   /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1025780 
>   /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1025780 
>   /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1025780 
>   /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1025780 
>   /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1025780 
> 
> Diff: http://reviewboard.kde.org/r/1094/diff
> 
> 
> Testing
> -------
> 
> Compiles and should work, but not tested.
> 
> 
> Screenshots
> -----------
> 
> Plasma themed KHistoryComboBox in Run Command applet
>   http://reviewboard.kde.org/r/1094/s/151/
> 
> 
> Thanks,
> 
> Michal
> 
>