Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit

[Michal Dutkiewicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/
-----------------------------------------------------------

(Updated 2009-09-22 10:30:38.640491)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

Updated to last changes.

Tested with KHistoryComboBox, KRestrictedLine and KTextEdit.


Summary
-------

This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1025780 
  /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1025780 
  /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1025780 
  /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1025780 
  /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1025780 
  /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1025780 

Diff: http://reviewboard.kde.org/r/1094/diff


Testing
-------

Compiles and should work, but not tested.


Screenshots
-----------

Plasma themed KHistoryComboBox in Run Command applet
  http://reviewboard.kde.org/r/1094/s/151/


Thanks,

Michal