Review Request: adding default colors format for kolourpicker and support for latex colors.
Marco Martin
notmart at gmail.com
Sun Sep 20 20:52:20 CEST 2009
> On 2009-09-20 18:51:25, Marco Martin wrote:
> > to me apart some style issues looks good
just a thing: since it changes the behaviour a bit contact the original author of it (pinotree on irc)
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1669/#review2405
-----------------------------------------------------------
On 2009-09-20 18:24:15, Tomaz Canabrava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1669/
> -----------------------------------------------------------
>
> (Updated 2009-09-20 18:24:15)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> remvoes the default menu that appears whenever we want to pick a color, not it uses a default colorstring format to do that, the color string format should be choosen before picking colors ( click on the round color button, go to Default Color Format and choose your favorite one), then just pick colors without the annoying menu popping everytime.
>
> Also, added support for latex colors.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.h 1026067
> /trunk/KDE/kdeplasma-addons/applets/kolourpicker/kolourpicker.cpp 1026067
>
> Diff: http://reviewboard.kde.org/r/1669/diff
>
>
> Testing
> -------
>
> everything working, no regressions found, no new bugs introduced ( from my tests )
>
>
> Thanks,
>
> Tomaz
>
>
More information about the Plasma-devel
mailing list