Review Request: Now playing dataengine

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1634/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch:
* Adds ArtUrl field (e.g. webkit scriptengine cannot handle QPixmap)
* Adds Url field (sometimes it's useful to know file name e.g. when there is no metadata)
* Updates metadata if CAN_PROVIDE_METADATA goes up and metadata is empty.

There was a concern that if it's used in a remove widget, urls are not valid. Is documentation enough for this (Not included yet)?


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/nowplayingengine.cpp 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playercontainer.cpp 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/juk.cpp 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/juk_p.h 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris.cpp 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris_p.h 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/player.h 1024661 
  /trunk/KDE/kdebase/workspace/plasma/generic/dataengines/nowplaying/playerinterface/player.cpp 1024661 

Diff: http://reviewboard.kde.org/r/1634/diff


Testing
-------

Basic testing with 'Now Rocking' plasmoid


Thanks,

Petri