Review Request: big revamp of Device Notifier

[Giulio Camuffo]

> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui, line 63
> > <http://reviewboard.kde.org/r/1370/diff/5/?file=10960#file10960line63>
> >
> >     I am not a native speaker either.. but this "the" seems strange to me

well, i tried with google translate but it leaves me quite confused: http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20anche%20le%20periferiche%20rimovibili and http://translate.google.it/translate_t?hl=it&ie=UTF-8&text=mostra+le+periferiche+rimovibili&sl=it&tl=en#it|en|mostra%20le%20periferiche%20rimovibili. I suppose we need to wait for a native speaker :)


> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp, line 194
> > <http://reviewboard.kde.org/r/1370/diff/5/?file=10968#file10968line194>
> >
> >     May I ask why do you need to go backward?

Sincerely, I don't know. I changed this months ago and I don't remember why. But now i tried to revert it and it seems to work anyway. 
I really should comment more the code!


> On 2009-09-10 18:18:27, Jacopo De Simoi wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp, line 342
> > <http://reviewboard.kde.org/r/1370/diff/5/?file=10968#file10968line342>
> >
> >     ManagerDialog should be NotifierDialog i suppose, here
> >

yes, a little oversight.


On 2009-09-10 18:18:27, Giulio Camuffo wrote:
> > I still don't like the fact that you have to click twice to select the action if there is only one available action.. we should find a solution for this..

I agree.
Maybe we could show the actions on hover. This would require then a single click, but on the other hand it could be a bit annoying if you have many devices and you have to get to the one on the other side of the applet.


- Giulio


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1370/#review2266
-----------------------------------------------------------


On 2009-09-01 16:55:56, Giulio Camuffo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1370/
> -----------------------------------------------------------
> 
> (Updated 2009-09-01 16:55:56)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This is a patch that modifies quite heavily the behaviour of the Device Notifier.
> It comes from here: http://kde-look.org/content/show.php/Device+Manager?content=106051
> It can show the not removable devices too, it can mount them automatically or with a click, since the "eject" button is a "mount" button when the volume is umounted. So that guy on the dot will be ok.
> It can hide some items in the same way as Dolphin's places (hide item/ show all).
> Finally, it shows the various opening actions under the device instead of calling that xp-ish window.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h 1013960 
>   /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp 1013960 
> 
> Diff: http://reviewboard.kde.org/r/1370/diff
> 
> 
> Testing
> -------
> 
> I'm using it every day since I released 0.1 on Kde-look. I tried all the options on my pc and they work. Some people on kde-look posted some comments about some problems, but it seems to me they are very particular cases, so in my opinion it is quite stable to go in trunk, but anyway review it! :)
> 
> 
> Screenshots
> -----------
> 
> screen
>   http://reviewboard.kde.org/r/1370/s/183/
> 
> 
> Thanks,
> 
> Giulio
> 
>