Review Request: RunnerManager: Whitelist enforcement (bugfix)

Aaron J. Seigo aseigo at kde.org
Fri Sep 11 00:14:55 CEST 2009


On September 10, 2009, you wrote:
> > On 2009-09-10 19:28:38, Aaron Seigo wrote:
> > > when setAllowedRunners is called, it removes any instantiated runners,
> > > resets the config values and then on next run the runners should be
> > > loaded based on that. where is this currently failing?
> 
> the description.isPluginEnabled() is loaded from plugin info and (for me)
>  doesn't work with the local config

right, because isPluginEnabled takes its default from the .desktop file. hm.

so setAllowedPlugins probably needs to store its list in a separate key and 
compare against it first. will commit a patch shortly.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090910/aa669eee/attachment.sig 


More information about the Plasma-devel mailing list