Review Request: RunnerManager: Whitelist enforcement (bugfix)

Ivan Cukic ivan.cukic+kde at gmail.com
Thu Sep 10 21:49:14 CEST 2009



> On 2009-09-10 19:28:38, Aaron Seigo wrote:
> > when setAllowedRunners is called, it removes any instantiated runners, resets the config values and then on next run the runners should be loaded based on that. where is this currently failing?

the description.isPluginEnabled() is loaded from plugin info and (for me) doesn't work with the local config


- Ivan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1565/#review2278
-----------------------------------------------------------


On 2009-09-10 19:19:21, Ivan Cukic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1565/
> -----------------------------------------------------------
> 
> (Updated 2009-09-10 19:19:21)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Whitelist enforcement - if the whitelist is set, then the runners are filtered by it (this is mainly a fix)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/runnermanager.cpp 1021493 
> 
> Diff: http://reviewboard.kde.org/r/1565/diff
> 
> 
> Testing
> -------
> 
> done testing in KRunner and Kickoff
> 
> 
> Thanks,
> 
> Ivan
> 
>



More information about the Plasma-devel mailing list