Review Request: Use QImageBlitz to draw gradients in plasma color wallpaper plugin

Shafqat Bhuiyan priomsrb at gmail.com
Sun Sep 6 01:14:19 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1528/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch is a follow up to http://reviewboard.kde.org/r/939/ which was(intentionally) not committed.

This patch allows the color wallpaper plugin to draw gradients. There are now 9 modes available:
- Solid
- Vertical
- Horizontal
- Diagonal
- Cross_diagonal
- Pyramid
- Rectangle
- Pipe_cross
- Elliptic

The difference between this patch and the previous review request is that this one uses QImageBlitz to draw the gradients. Also the wallpaper is now more efficient as it draws on a pixmap instead of directly to the screen.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/wallpapers/color/CMakeLists.txt 1020293 
  trunk/KDE/kdebase/workspace/plasma/wallpapers/color/color.h 1020293 
  trunk/KDE/kdebase/workspace/plasma/wallpapers/color/color.cpp 1020293 
  trunk/KDE/kdebase/workspace/plasma/wallpapers/color/config.ui 1020293 
  trunk/KDE/kdebase/workspace/plasma/wallpapers/color/plasma-wallpaper-color.desktop 1020293 

Diff: http://reviewboard.kde.org/r/1528/diff


Testing
-------

Tested in trunk


Screenshots
-----------

Configuration Dialog
  http://reviewboard.kde.org/r/1528/s/201/


Thanks,

Shafqat



More information about the Plasma-devel mailing list