Review Request: plasmapkg & wallpaper

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2006/#review2852
-----------------------------------------------------------



/trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp
<http://reviewboard.kde.org/r/2006/#comment2218>

    hm; either wallpaperplugin needs to be added to the command line information above or, imho even better, it should autodetect whether it has a bunch of images or a scripted wallpaperplugin package and just "do the right thing" based on that. a bit more code, but would be a nicer UI.



/trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp
<http://reviewboard.kde.org/r/2006/#comment2217>

    with this there really is no point in having "upgrade". the idea is that install should always be safe and not silently obliterate something that already exists there just because of a naming collision.


- Aaron


On 2009-10-29 07:00:48, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2006/
> -----------------------------------------------------------
> 
> (Updated 2009-10-29 07:00:48)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> * install wallpaper plasma packages
> * auto detect (plasmoids,) dataengines, runners and wallpapers (install them without --type)
> * Remove previous package also with --install
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/runtime/plasma/tools/plasmapkg/main.cpp 1042090 
> 
> Diff: http://reviewboard.kde.org/r/2006/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>