Moved runner "Amarok" to kdereview

[Aaron J. Seigo]

On October 20, 2009, Jan Gerrit Marker wrote:
> Hello,
> 
> > I would prefer to make it more generic.
> 
> Done that in the code. If you say that it is ok, I'll change the runner's
> description and the name (maybe to "Control Audio Player"?).

sure.

> Does anybody know some MRPIS players so I can add them to the combo box? I
> made the box editable but I would like to add the most famous players.

http://wiki.xmms2.xmms.se/wiki/Media_Player_Interfaces#Projects_involved

seems there's an add-on for Songbird as well.

> > > * caching the values of songsInPlaylist, prevSongAvailable and
> > > nextSongAvailable would be a good idea instead of calling them
> > > repeatedly in match()
> 
> I tried this, I'm not sure if I've done it correctly. So one question to
>  this: When is the signal prepare() emitted?

before calls to match() start happening (apidox is your friend! :)

and yes, looks like you did it correctly ... cool.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20091020/6c120c5d/attachment.sig