Review Request: Use window() as KNotificationItem::associatedWidget() to avoid native widgets

Christoph Feck christoph at maxiom.de
Wed Oct 7 17:13:11 CEST 2009



> On 2009-09-25 09:55:13, Marco Martin wrote:
> > well, looking at all the code again it would just have th same effect of setAssociatedWidget(0), simply the activated signal(clicking) won't do anything by itself but forward the signal itself, you're right, i need to expand the apidox on that.
> > 
> > aaanyways, the patch looks good, please go for it.

Thanks, the problem that I was trying to solve seems to be a Qt 4.6 bug. When I use the raster graphicssystem, for certain actions, widgets are promoted to native widgets internally. I have yet to find out why.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1707/#review2465
-----------------------------------------------------------


On 2009-09-24 03:20:31, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1707/
> -----------------------------------------------------------
> 
> (Updated 2009-09-24 03:20:31)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Summary
> -------
> 
> Use the window() of the passed parent() as the associated widget to avoid creating a native widget for the child due to all the winId() calls. Alien widgets are much faster.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/notifications/knotificationitem.cpp 1027406 
> 
> Diff: http://reviewboard.kde.org/r/1707/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>



More information about the Plasma-devel mailing list