Review Request: WebView Kinetic Scrolling

[Marco Martin]

On Saturday 03 October 2009, Kenneth Christiansen wrote:
> Would be cool if you guys could have a look at the QGraphicsWebView in
> WebKit trunk, so we can get feedback on the API before we release it
> with Qt 4.6.

api wise of course it doesn't have much, because as our plasma one just wraps 
the most useful functions of qwebframe and qwebpage,, however just taking a 
quick look...

progressChanged() signal. we and qwebpage too use loadProgress() maybe using 
the same name for consitency?

isInteractive() is isContentEditable() of qwebpage? if it is they should be 
called the same way, if not what is the difference?

atm i can't come up with other stuff :)

Cheers,
Marco Martin

> Cheers,
> Kenneth
>
> On Sat, Oct 3, 2009 at 10:16 AM, Marco Martin <notmart at gmail.com> wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/1764/#review2534
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > apart a couple of stye issues it's ok
> >
> >
> > trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> > <http://reviewboard.kde.org/r/1764/#comment1859>
> >
> >    if (event->pos().x()
> >
> >
> >
> > trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> > <http://reviewboard.kde.org/r/1764/#comment1860>
> >
> >    if (me.isAccepted()) {
> >
> >
> >
> > trunk/KDE/kdelibs/plasma/widgets/webview.cpp
> > <http://reviewboard.kde.org/r/1764/#comment1861>
> >
> >    also there, no spaces
> >
> >
> > - Marco
> >
> > On 2009-10-03 13:07:41, igorto wrote:
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> http://reviewboard.kde.org/r/1764/
> >> -----------------------------------------------------------
> >>
> >> (Updated 2009-10-03 13:07:41)
> >>
> >>
> >> Review request for Plasma, Aaron Seigo, Marco Martin, and Adenilson
> >> Cavalcanti.
> >>
> >>
> >> Summary
> >> -------
> >>
> >> Add support for kinetic scrolling in webview widget.
> >>
> >> TODO:
> >>
> >> -Make Horizontal Kinetic Scrolling works
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   trunk/KDE/kdelibs/plasma/widgets/webview.h 1030897
> >>   trunk/KDE/kdelibs/plasma/widgets/webview.cpp 1030897
> >>
> >> Diff: http://reviewboard.kde.org/r/1764/diff
> >>
> >>
> >> Testing
> >> -------
> >>
> >> webbrowser
> >>
> >>
> >> Thanks,
> >>
> >> igorto
> >
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel


-- 
Marco Martin