Review Request: Add to itemBackground signals to track animation progress

Aaron Seigo aseigo at kde.org
Fri Oct 2 18:07:37 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1757/#review2525
-----------------------------------------------------------

Ship it!


yes, the progress is needed in that signal to coordinate animations.

my only hesitation on this is if we could be using kinetic and allowing the animation for moving this item to be coordinated with other animations that way; it would mean being able to add the background animation to a random animation group of the item's choosing.

if that's not feasible, then this patch is the best solution i can see. 

- Aaron


On 2009-10-02 09:10:16, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1757/
> -----------------------------------------------------------
> 
> (Updated 2009-10-02 09:10:16)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> Adds signals useful to animate activation of items or to sync the activation with the IB movement. 
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/itembackground.h 1030313 
>   trunk/KDE/kdelibs/plasma/widgets/itembackground.cpp 1030313 
> 
> Diff: http://reviewboard.kde.org/r/1757/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>



More information about the Plasma-devel mailing list