Review Request: Delay updating shape until next event cycle

Jacopo De Simoi wilderkde at gmail.com
Fri Oct 2 10:34:18 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1756/
-----------------------------------------------------------

Review request for Plasma, Aaron Seigo and Marco Martin.


Summary
-------

Delay updating the shape of the itemBackground after some change event to allow the parent of the target item to resize itself; 
what happens right now is that itemBackground grabs the event before the parent and is cut if the parent needs to be resized and has the itemClipsChildrenToShape flag set.     


Diffs
-----

  trunk/KDE/kdelibs/plasma/widgets/itembackground.h 1030313 
  trunk/KDE/kdelibs/plasma/widgets/itembackground.cpp 1030313 

Diff: http://reviewboard.kde.org/r/1756/diff


Testing
-------

it works as expected, the parent is resized beforehand and clipping does not occur.


Thanks,

Jacopo



More information about the Plasma-devel mailing list