Review Request: Add support for single Runner queries to krunner (part I: libplasma)

Aaron Seigo aseigo at kde.org
Tue Nov 24 19:40:13 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/#review3253
-----------------------------------------------------------

Ship it!


- Aaron


On 2009-11-24 12:59:38, Jacopo De Simoi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2090/
> -----------------------------------------------------------
> 
> (Updated 2009-11-24 12:59:38)
> 
> 
> Review request for Plasma, Aaron Seigo and Ryan Bitanga.
> 
> 
> Summary
> -------
> 
> This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs;
> 
> A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. 
> On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery.
> 
> The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/abstractrunner.h 1052445 
>   trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1052445 
>   trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1052445 
>   trunk/KDE/kdelibs/plasma/runnercontext.h 1053618 
>   trunk/KDE/kdelibs/plasma/runnercontext.cpp 1053618 
>   trunk/KDE/kdelibs/plasma/runnermanager.h 1052445 
>   trunk/KDE/kdelibs/plasma/runnermanager.cpp 1052445 
> 
> Diff: http://reviewboard.kde.org/r/2090/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jacopo
> 
>



More information about the Plasma-devel mailing list