Review Request: Add support for single Runner queries to krunner (part I: libplasma)

Jacopo De Simoi wilderkde at gmail.com
Tue Nov 24 13:59:38 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2090/
-----------------------------------------------------------

(Updated 2009-11-24 12:59:38.449340)


Review request for Plasma, Aaron Seigo and Ryan Bitanga.


Changes
-------

Do not load single runners if not selected; for now export them only if so, this will be dropped when loading-on-the-fly is implemented
this still needs to load them on-the-fly, but it can be easily fixed after commit


Summary
-------

This is the API needed by the new single Runner mode for krunner (more on usecases in part II:krunner) for kdelibs;

A runner can now optionally define a Default syntax; if this is the case, the runner will be exposed as single-runner-mode capable. 
On request, the default syntax will be replaced to the empty query in RunnerManager::launchQuery.

The context is aware of the fact that we are in single runner query mode in case the runners need to change their behaviour accordingly (e.g. to _not_ discard queries with less than 3 chars)


Diffs (updated)
-----

  trunk/KDE/kdelibs/plasma/abstractrunner.h 1052445 
  trunk/KDE/kdelibs/plasma/abstractrunner.cpp 1052445 
  trunk/KDE/kdelibs/plasma/private/abstractrunner_p.h 1052445 
  trunk/KDE/kdelibs/plasma/runnercontext.h 1053618 
  trunk/KDE/kdelibs/plasma/runnercontext.cpp 1053618 
  trunk/KDE/kdelibs/plasma/runnermanager.h 1052445 
  trunk/KDE/kdelibs/plasma/runnermanager.cpp 1052445 

Diff: http://reviewboard.kde.org/r/2090/diff


Testing
-------


Thanks,

Jacopo



More information about the Plasma-devel mailing list