Review Request: Bookmarks runner: make the firefox bookmarks support work when there is only on firefox profile

Jean-Baptiste Rouault jbrouault at gmail.com
Mon Nov 9 18:21:54 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2099/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This patch makes the firefox bookmarks support in the bookmarks runner work
even if there is only one firefox profile.
It also iterates over the groups which actually exist in the profiles.ini
file to avoid unnecessary looping.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/generic/runners/bookmarks/bookmarksrunner.cpp 1046722 

Diff: http://reviewboard.kde.org/r/2099/diff


Testing
-------

Tested with a profiles.ini containing only one profile, and another one
containing more than 2 profiles.


Thanks,

Jean-Baptiste



More information about the Plasma-devel mailing list