Review Request: Digital Clock applet date formatting

[John Layt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1877/
-----------------------------------------------------------

(Updated 2009-11-04 01:05:16.263057)


Review request for Plasma.


Changes
-------

Fewer date format options, more time format options, fix some i18n mistakes, updated screenshots.

I wasn't entirely happy with the number of entries in the combo in the original change caused by having duplicates for both US and international formats listed.  To avoid this, I have now used just the en_US date formats, but made the format strings themselves translatable so each i18n team can decide what format is right for their language.  The down side is it now ties date formatting to language which is not always a good heuristic for locale, for example where someone is using es for language but US for locale so will get the wrong format.  Is this an acceptable compromise?

Having explanatory text before the example looks rather crowded and hard to pick out, should it just be the example date?

As an experiment and in response to bug 210613 I've tried the same config method on the Time Format as well, I'm happy to rip it out if it's not a useful addition.


Summary
-------

As discussed on the plasma mailing list.  The Digital Clock applet has problems with l10n and i18n when formatting the date to be displayed, this change fixes these problems and simplifies the config while allowing more options.

The config GUI has changed from 3 tick-boxes to a single combobox of valid formats, which now includes the system locale formats.  Existing config files are automatically converted to the new config format.

Comment welcomed on available formats and wording in combobox


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.h 1035179 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clock.cpp 1035364 
  trunk/KDE/kdebase/workspace/plasma/generic/applets/digital-clock/clockConfig.ui 1035179 

Diff: http://reviewboard.kde.org/r/1877/diff


Testing
-------

Tested conversion process for existing configs and new configs.  Tested selecting all available formats in gui.


Screenshots (updated)
-----------

Settings GUI
  http://reviewboard.kde.org/r/1877/s/249/
Time formats
  http://reviewboard.kde.org/r/1877/s/250/
Date formats
  http://reviewboard.kde.org/r/1877/s/251/


Thanks,

John