Review Request: Moonrise/set for time dataengine

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/680/
-----------------------------------------------------------

(Updated 2009-05-10 03:41:26.842682)


Review request for Plasma.


Changes
-------

Updated diff with on demand allocation of sun and moon.


Summary
-------

Moonrise/set patch using new TimeSource in time dataengine. This also changes all sun and moon phase calculation code so same code can be used for all the calculations. This is too late for 4.3, but I'll post it here so it won't get lost.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/phases.cpp 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.h 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.cpp 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.cpp PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 965999 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 965999 

Diff: http://reviewboard.kde.org/r/680/diff


Testing
-------


Thanks,

Petri