Review Request: Moonrise/set for time dataengine

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/680/#review1099
-----------------------------------------------------------


putting things in TimeSource was a way to avoid constant allocations. on the one hand, i suppose/hope that people won't be asking for to-the-second accurate sun/moon positions from the time engine, but this still seems like sort of a step back to where we're doing allocations that probably could be re-used every time we want to figure something out. what'd recommend at least is adding a Sun* and Moon* pointer to TimeSource and if it's going to do sun and moon calcs to allocate them then. tht way they are allocated just once. it does mean they hang around even if the request is only updated every 10 minutes or whatever.  my concern is for rapid updates.

- Aaron


On 2009-05-09 04:43:51, Petri Damstén wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/680/
> -----------------------------------------------------------
> 
> (Updated 2009-05-09 04:43:51)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Moonrise/set patch using new TimeSource in time dataengine. This also changes all sun and moon phase calculation code so same code can be used for all the calculations. This is too late for 4.3, but I'll post it here so it won't get lost.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/phases.cpp 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.h 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.cpp 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timeengine.cpp 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 965523 
>   /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 965523 
> 
> Diff: http://reviewboard.kde.org/r/680/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Petri
> 
>