Review Request: non-modal mode for KShortcutsDialog

Chani chanika at gmail.com
Sat May 2 04:49:41 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/652/
-----------------------------------------------------------

Review request for kdelibs and Plasma.


Summary
-------

kshortcutsdialog was designed to be modal and only modal. that doesn't work very well for plasma. :) I added the possibility to use it non-modally. I need this to finish off http://reviewboard.kde.org/r/639/


Diffs
-----

  /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.h 961912 
  /trunk/KDE/kdelibs/kdeui/dialogs/kshortcutsdialog.cpp 961912 

Diff: http://reviewboard.kde.org/r/652/diff


Testing
-------

modal and non-modal modes work with the plasma settings dialog


Thanks,

Chani



More information about the Plasma-devel mailing list