Review Request: Makes the configuration of the comic plasmoid easier to use

[Matthias Fuchs]

> On 2009-03-29 09:22:35, Davide Bettio wrote:
> > Screenshot: 
> > <http://reviewboard.kde.org>
> >
> >     I don't think that we need this checkbox anymore.
> >

Why should it be removed?

Imo it combines both advantages, if one doesn't want to use tabs they easily can switch the comics without searching in a list which one is activated, while someone that wants to use tabs can mark all the comics they want to have.

Btw. agateau meant (on the usability ml) that it would be better to check the items rather then marking them, as "it's less surprising for users since a selection is not expected to be persistent."

What do you think about that? If I'd add checkboxes I think I also should add select/deselect all buttons as there would not be an easy way to mark many entries anymore (now pressing your left-mouse-button and moving up/down).


- Matthias


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/461/#review695
-----------------------------------------------------------


On 2009-03-29 04:33:47, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/461/
> -----------------------------------------------------------
> 
> (Updated 2009-03-29 04:33:47)
> 
> 
> Review request for Plasma and Davide Bettio.
> 
> 
> Summary
> -------
> 
> Whenever the user ticks "Use Tabs" the view changes and the available comics are displayed in a listview, clicking at them marks them and adds them as tabs if ok is pressed. Otherwise it is similar to the current situation.
> 
> I'm not sure if I should add "Select All"-, "Deselect All"-Buttons. What do you think?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comicSettings.ui 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.h 946187 
>   /trunk/KDE/kdeplasma-addons/applets/comic/configwidget.cpp 946187 
> 
> Diff: http://reviewboard.kde.org/r/461/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/461/s/82/
> 
>   http://reviewboard.kde.org/r/461/s/83/
> 
> 
> Thanks,
> 
> Matthias
> 
>