Review Request: The option Date for plasmoid Notes.
Maxime Hermouet
moux2003 at hotmail.com
Wed Mar 25 17:20:44 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/415/#review616
-----------------------------------------------------------
trunk/KDE/kdeplasma-addons/applets/notes/config.ui
<http://reviewboard.kde.org/r/415/#comment398>
As we told me the first time I submited a diff, for this file don't put all fonts here, it should be done by itself
trunk/KDE/kdeplasma-addons/applets/notes/config.ui
<http://reviewboard.kde.org/r/415/#comment401>
why is there a label name spellCheck_2 here ?
trunk/KDE/kdeplasma-addons/applets/notes/notes.h
<http://reviewboard.kde.org/r/415/#comment402>
please delete white spaces that are useless to help keeping a clean source code
trunk/KDE/kdeplasma-addons/applets/notes/notes.h
<http://reviewboard.kde.org/r/415/#comment403>
same as line 93
trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp
<http://reviewboard.kde.org/r/415/#comment404>
again white spaces
trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp
<http://reviewboard.kde.org/r/415/#comment406>
check all other white spaces, and good luck
trunk/KDE/kdeplasma-addons/applets/notes/plasma-notes-default.desktop
<http://reviewboard.kde.org/r/415/#comment405>
don't change this file to yours
- Maxime
On 2009-03-25 07:52:15, Sylvain Jolivet wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/415/
> -----------------------------------------------------------
>
> (Updated 2009-03-25 07:52:15)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> This patch adds to the plasmoid notes the possibility to show the (updated) date when a note is created(modified) .
>
> If you notice any problems with this new option just tell me
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/notes/notes.h 944381
> trunk/KDE/kdeplasma-addons/applets/notes/notes.cpp 944381
> trunk/KDE/kdeplasma-addons/applets/notes/config.ui 944381
> trunk/KDE/kdeplasma-addons/applets/notes/plasma-notes-default.desktop 944381
>
> Diff: http://reviewboard.kde.org/r/415/diff
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
>
> http://reviewboard.kde.org/r/415/s/72/
>
>
> Thanks,
>
> Sylvain
>
>
More information about the Plasma-devel
mailing list