Review Request: Support to change icon for Kickoff applet

[Christian Loose]

> On 2009-03-23 12:54:20, Aaron Seigo wrote:
> > /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp, line 197
> > <http://reviewboard.kde.org/r/404/diff/1/?file=3934#file3934line197>
> >
> >     should this go into the globalConfig()? if it went into config() people can set this per-launcher button?

I agree, it should go to globalConfig(). Will change and commit it.


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/404/#review578
-----------------------------------------------------------


On 2009-03-23 12:21:53, Christian Loose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/404/
> -----------------------------------------------------------
> 
> (Updated 2009-03-23 12:21:53)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The patch adds a new config option to the Kickoff applet. The option allows to change the icon of the applet like it's already possible for the "classic style menu" (simplelauncher)
> 
> 
> This addresses bug 182342.
>     https://bugs.kde.org/show_bug.cgi?id=182342
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 943377 
> 
> Diff: http://reviewboard.kde.org/r/404/diff
> 
> 
> Testing
> -------
> 
> Tested with svn trunk.
> 
> 
> Screenshots
> -----------
> 
> configuration dialog
>   http://reviewboard.kde.org/r/404/s/66/
> icon changed
>   http://reviewboard.kde.org/r/404/s/67/
> 
> 
> Thanks,
> 
> Christian
> 
>