Review Request: Add KTTSD support to libplasmaclock to announce the hour

[Trever Fischer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/
-----------------------------------------------------------

(Updated 2009-03-21 21:58:52.032707)


Review request for Plasma.


Changes
-------

* Updated to use an async dbus call.
* Changed the string sent to KTTS so times like 3:05 don't come out as "three zero five"
* Merged the calendar and announcement pages into a "General" page, renamed the "General" pages supplied by the two clock applets into an "Appearance" page.
* Changed the Timezone icon to an i18n-related icon to avoid confusion with two pages with Applet::icon() as the icon.
* Updated screenshots


Summary
-------

This patch adds a new page to the configuration that lets the applet speak the time every nth minute of the hour. It defaults to never. The only major problem I see right now is the awkward wording of the spinbox.


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt 942542 
  trunk/KDE/kdebase/workspace/libs/plasmaclock/calendarConfig.ui 942542 
  trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 942542 
  trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 942542 
  trunk/KDE/kdebase/workspace/libs/plasmaclock/generalConfig.ui PRE-CREATION 
  trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp 942542 
  trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp 942542 

Diff: http://reviewboard.kde.org/r/380/diff


Testing
-------

I've got it running in my everyday plasma session without problems.


Screenshots (updated)
-----------

General Page
  http://reviewboard.kde.org/r/380/s/62/


Thanks,

Trever