Review Request: Add KTTSD support to libplasmaclock to announce the hour

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/380/#review550
-----------------------------------------------------------


cool feature; small issue with the use of dbus (blocking vs non-blocking) and i think the configuration should change up a bit; the General page could be renamed to Appearance and the Calendar and Announcement pages could be merged into a new General page?


trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp
<http://reviewboard.kde.org/r/380/#comment333>

    this should be asyncCall rather than call, as we don't care about the return and shouldn't block on it.


- Aaron


On 2009-03-21 16:39:35, Trever Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/380/
> -----------------------------------------------------------
> 
> (Updated 2009-03-21 16:39:35)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch adds a new page to the configuration that lets the applet speak the time every nth minute of the hour. It defaults to never. The only major problem I see right now is the awkward wording of the spinbox.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/libs/plasmaclock/CMakeLists.txt 942542 
>   trunk/KDE/kdebase/workspace/libs/plasmaclock/announcementConfig.ui PRE-CREATION 
>   trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 942542 
>   trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 942542 
>   trunk/KDE/kdebase/workspace/plasma/applets/analog-clock/clock.cpp 942542 
>   trunk/KDE/kdebase/workspace/plasma/applets/digital-clock/clock.cpp 942542 
> 
> Diff: http://reviewboard.kde.org/r/380/diff
> 
> 
> Testing
> -------
> 
> I've got it running in my everyday plasma session without problems.
> 
> 
> Screenshots
> -----------
> 
> Settings Page
>   http://reviewboard.kde.org/r/380/s/61/
> 
> 
> Thanks,
> 
> Trever
> 
>