Review Request: better popupposition

Aaron Seigo aseigo at kde.org
Fri Mar 20 23:23:43 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/374/#review543
-----------------------------------------------------------

Ship it!


- Aaron


On 2009-03-20 14:15:04, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/374/
> -----------------------------------------------------------
> 
> (Updated 2009-03-20 14:15:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> some special cases when the item is in a panel:
> try to not exit from the panel boundaries, so won't look cutted away (fails only in the case when the panel is shorter than the applet, in this case no magic force can make it look good :))
> try to center the popup respect to the applet, looks more organic and  greatly improves the look of taskbar groups popups and tooltips
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 941938 
> 
> Diff: http://reviewboard.kde.org/r/374/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list