Review Request: Fix 'list-dictionaries' output of dictionary data engine
Christian Loose
christian.loose at hamburg.de
Fri Mar 20 22:32:12 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/375/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
This patch fixes the parsing of the "SHOW DB" output in the dictionary data engine.
Otherwise the "list-dictionaries" output included:
- Status codes 250 and 110
- Empty lines
- Lines starting with a dot
Also the key value of "list-dictionaries" was wrong. It always contained the first word of the description.
Diffs
-----
/trunk/KDE/kdebase/workspace/plasma/dataengines/dict/dictengine.cpp 941485
Diff: http://reviewboard.kde.org/r/375/diff
Testing
-------
Tested with svn trunk using plasmaengineexplorer.
Thanks,
Christian
More information about the Plasma-devel
mailing list