Review Request: Add a message counter to Leave a Note

Jesper Thomschutz jesperht at yahoo.com
Thu Mar 12 08:42:46 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/273/
-----------------------------------------------------------

(Updated 2009-03-12 00:42:42.815234)


Review request for Plasma.


Changes
-------

Thanks for the feedback Aaron. In this patch I removed configuration options and am using i18np.


Summary
-------

In this patch I add an extra Label below the "send" button showing the number of messages that have been sent. This can be disabled in the configuration. Also, I remove the weird verboseLog(QString) function in the header (unused?)


Diffs (updated)
-----

  /trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.h 938439 
  /trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.cpp 938439 

Diff: http://reviewboard.kde.org/r/273/diff


Testing
-------

Played with it quite a bit. 100% bug free for sure ;)


Thanks,

Jesper



More information about the Plasma-devel mailing list