Review Request: Add a message counter to Leave a Note

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/273/#review455
-----------------------------------------------------------


i don't see why this should be configurable; beyond that, i also don't see where the count is reset. obviously this works on the screensaver in an ok fashion because it gets destroyed and created each time, but won't work elsewhere where it isn't destroyed before the user reads the messages. i don't know if there's a way around that, however, and it might be just fine to leave it as it is. anyways, a couple of things to fix, as per the comments below, and it go in without the configuration option.


/trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.cpp
<http://reviewboard.kde.org/r/273/#comment284>

    there is no reason to make this configurable.



/trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.cpp
<http://reviewboard.kde.org/r/273/#comment285>

    this should be:
    
    i18np("One unread message", "%1 unread messages", mMessageCounter);
    
    i18np is for plurals (ergo the 'p' in the method name)


- Aaron


On 2009-03-11 12:31:28, Jesper Thomschutz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/273/
> -----------------------------------------------------------
> 
> (Updated 2009-03-11 12:31:28)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> In this patch I add an extra Label below the "send" button showing the number of messages that have been sent. This can be disabled in the configuration. Also, I remove the weird verboseLog(QString) function in the header (unused?)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.h 938323 
>   /trunk/KDE/kdeplasma-addons/applets/leavenote/leavenote.cpp 938323 
>   /trunk/KDE/kdeplasma-addons/applets/leavenote/widget.ui 938323 
> 
> Diff: http://reviewboard.kde.org/r/273/diff
> 
> 
> Testing
> -------
> 
> Played with it quite a bit. 100% bug free for sure ;)
> 
> 
> Thanks,
> 
> Jesper
> 
>