Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button

[Mohammad Mehdi Salem Naraghi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/63/
-----------------------------------------------------------

(Updated 2009-03-04 15:51:16.224904)


Review request for Plasma and Aaron Seigo.


Changes
-------

Fixes:
* Fixed and tested the animation with all possible panel locations (top, bottom, left, right).
* decreased the singleShot timer delay to 250ms for the animation to start.
Remaining Issues:
* The timer of the animation is started whenever the widget receives a showEvent. Since in case of plasmoids the showEvent is always an internal showEvent handled _before_ the widget is shown I use a singleShot Timer introducing a delay of 250 ms for the animation to start. That is an awkward hack. There should be a way to start the animation immediately after the kickoff window is popped up by clicking on the start button. Any Ideas? 


Summary
-------

A little animation that mimics the behaviour of my sony erricsson handy whenever I get to the main menu. The Icons in kickoff's tabbar are all placed at the center of the tabbar before moving towards their intended location when the menu is displayed. It's a hack as of now and doesn't even work when the panel is placed on the right or left screen edge. But that's pretty easy to fix if you guys like that behaviour. I am not sure, maybe the thing is superfluous but hey, I like small useless animations. 


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 934862 
  trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 934862 

Diff: http://reviewboard.kde.org/r/63/diff


Testing
-------

the animation doesn't work (yet) if the panel is placed on the right or left screen edge. But adding support for that is pretty straightforward.


Thanks,

Mohammad Mehdi