Review Request: simple animation of tabbar icons everytime kickoff is launched by pressing the KDE start button

[Mohammad Mehdi Salem Naraghi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/63/
-----------------------------------------------------------

(Updated 2009-03-03 05:30:26.303511)


Review request for Plasma and Aaron Seigo.


Changes
-------

finally managed to upload the diff correctly :-D


Summary
-------

A little animation that mimics the behaviour of my sony erricsson handy whenever I get to the main menu. The Icons in kickoff's tabbar are all placed at the center of the tabbar before moving towards their intended location when the menu is displayed. It's a hack as of now and doesn't even work when the panel is placed on the right or left screen edge. But that's pretty easy to fix if you guys like that behaviour. I am not sure, maybe the thing is superfluous but hey, I like small useless animations. 


Diffs (updated)
-----

  trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.h 932966 
  trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/tabbar.cpp 932966 

Diff: http://reviewboard.kde.org/r/63/diff


Testing
-------

the animation doesn't work (yet) if the panel is placed on the right or left screen edge. But adding support for that is pretty straightforward.


Thanks,

Mohammad Mehdi