Review Request: a text browser widget

Aaron Seigo aseigo at kde.org
Tue Mar 3 06:27:16 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/217/#review340
-----------------------------------------------------------

Ship it!


sensible addition :)


/trunk/KDE/kdelibs/plasma/widgets/textbrowser.cpp
<http://reviewboard.kde.org/r/217/#comment209>

    extra spaces in the ()s


- Aaron


On 2009-03-01 14:55:58, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/217/
> -----------------------------------------------------------
> 
> (Updated 2009-03-01 14:55:58)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this is a KTextbrowser in a proxy widget, was thinking about making the textedit widget a readonly mode to be a surrogate but seems to be really too much convinced to be an editor...
> i think it would be quite used, everytime a chunk of formatted text needs to be displayed and webkit is overkill for the job
> this is born from an attempt to make twitter applet finally behave sane and this is the first part (important that now if it doesn't have scrollbars and has a fixed size policy it resizes quite nicely in vertical layouts)
> the secon part work in progress will be a scrollarea to put generic widgets in it 
> sneak peek:http://www.notmart.org/misc/microblogging-scroll.ogv
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/widgets/textbrowser.h PRE-CREATION 
>   /trunk/KDE/kdelibs/plasma/widgets/textbrowser.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/217/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list