Review Request: Comic applet using Plasma::Widgets

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/145/#review328
-----------------------------------------------------------

Ship it!


looks good...

on a semi-related note, i really think offering a configuration option for the style of arrows is a mistake. the arrows on hover is much more in the spirit of Plasma and the graphics for them look so much better. it offer the maximal space for content as well. i really see no measurable benefit to offering the configuration option other than "because we can". meanwhile, there's more code to maintain and more buttons and levers for users to manage. just my 0.02


/trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h
<http://reviewboard.kde.org/r/145/#comment207>

    this actually looks like a nice candidate for libplasma at some point, as i'm sure other widgets will want arrows as well. i'll keep my eyes open for such widgets and when they appear, maybe we can migrate this over.
    
    



/trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h
<http://reviewboard.kde.org/r/145/#comment208>

    how about Plasma::Direction? it already exists :)


- Aaron


On 2009-02-28 07:59:03, Matthias Fuchs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/145/
> -----------------------------------------------------------
> 
> (Updated 2009-02-28 07:59:03)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> I converted the comic applet to use Plasma::Widgets and basically everything works nice.
> 
> I have some questions though:
> 
> * Is there a way to avoid recreating the layout (ComicApplet::createLayout() in this case )?
> * Is there a way to add SpacerItems, so that mLabelId would be on the left of bottomLayout and only use as much space as needed, while mLabelUrl would be on the right and only use as much space needed as well?
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 930543 
>   /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.cpp PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 931593 
>   /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 931593 
>   /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION 
>   /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/145/diff
> 
> 
> Testing
> -------
> 
> Plasma::Labels do not adapt to the size of the text here.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.kde.org/r/145/s/42/
> 
> 
> Thanks,
> 
> Matthias
> 
>