Review Request: Place the user avatar next to the user/computer info in Kickoff

Jonathan Thomas echidnaman at kubuntu.org
Mon Jun 22 18:24:14 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/870/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

In the KDE kickoff menu, the avatar currently appears next to the menu search bar. It should be next to the username since the avatar and username are related information. See screenshot.
(This is a seele-recommended fix, see https://launchpad.net/bugs/389744 )
Here's the before picture: http://launchpadlibrarian.net/28128348/avatar.png

The patch basically moves the search for the user icon to launcher.cpp, and places either the found user icon-- or the generic user-identity icon if none is found-- next to the user/computer info. The search icon has been made smaller so that the new layout uses just as much space as the old layout.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/searchbar.cpp 978774 
  /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 978774 

Diff: http://reviewboard.kde.org/r/870/diff


Testing
-------

I have tested it. It's a fairly straightforward patch.


Screenshots
-----------

After
  http://reviewboard.kde.org/r/870/s/134/


Thanks,

Jonathan



More information about the Plasma-devel mailing list