Review Request: Containment::isToolBoxOpen()

[Marco Martin]

> On 2009-06-04 10:18:20, Aaron Seigo wrote:
> > the patch itself looks fine, but i fixed this problem once already by properly tracking the toolbox signals in PanelView ... did this get broken again?

no the signals works correctly, the problem is when add spacer is pressed. here a new spacer gets created, but since the toolbox status isn't changed the spacer can't know about the toolbox status, so it doesn't get painted


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/795/#review1269
-----------------------------------------------------------


On 2009-06-04 06:05:50, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/795/
> -----------------------------------------------------------
> 
> (Updated 2009-06-04 06:05:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
>  adds a function to discover if the toolbox is open: now we have a signal to notice the change of state, we can open and close it but we can't know the state. it's needed to fix a problem in the panel spacer (when the spacer is added is not painted: the toolbox has to be closed and open again to make the spacer paint)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/containment.h 977442 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 977442 
> 
> Diff: http://reviewboard.kde.org/r/795/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>