Review Request: Containment::isToolBoxOpen()

Aaron Seigo aseigo at kde.org
Thu Jun 4 19:18:16 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/795/#review1269
-----------------------------------------------------------


the patch itself looks fine, but i fixed this problem once already by properly tracking the toolbox signals in PanelView ... did this get broken again?

- Aaron


On 2009-06-04 06:05:50, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/795/
> -----------------------------------------------------------
> 
> (Updated 2009-06-04 06:05:50)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
>  adds a function to discover if the toolbox is open: now we have a signal to notice the change of state, we can open and close it but we can't know the state. it's needed to fix a problem in the panel spacer (when the spacer is added is not painted: the toolbox has to be closed and open again to make the spacer paint)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/containment.h 977442 
>   /trunk/KDE/kdelibs/plasma/containment.cpp 977442 
> 
> Diff: http://reviewboard.kde.org/r/795/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list