Issues with setupMatchSession/matchSessionComplete in RunnerManager

[Ryan P. Bitanga]

On Thu, Jul 30, 2009 at 11:29 PM, Ryan P. Bitanga<ryan.bitanga at gmail.com> wrote:
> On Thu, Jul 30, 2009 at 9:28 AM, Aaron J. Seigo<aseigo at kde.org> wrote:
>> On Wednesday 29 July 2009, Ryan P. Bitanga wrote:
>>> On Thu, Jul 30, 2009 at 2:04 AM, Aaron J. Seigo<aseigo at kde.org> wrote:
>>> > On Wednesday 29 July 2009, Ryan P. Bitanga wrote:
>>> >> On Thu, Jul 30, 2009 at 12:43 AM, Aaron J. Seigo<aseigo at kde.org> wrote:
>>> >> > On Wednesday 29 July 2009, Ryan P. Bitanga wrote:
>>> >>
>>> >> so I think the best place to do this would be in
>>> >> the destructor of FindMatchesJob. We'd check if the queue is empty,
>>> >> and if it is then we can emit the teardown signal.
>>> >
>>> > there'd be some corner cases there, such as if there are no
>>> > FindMatchesJobs when teardown is requested ... how about in
>>> > RunnerManagerPrivate::jobDone()? see attached patch...
>>>
>>> I like the fact that this keeps everything in RunnerManager instead of
>>> having the logic separated between files. Doesn't this suffer from the
>>> same problem though? If there are no jobs to begin with, the slot
>>> won't be called.
>>
>> that's why there's a call to checkTearDown() in
>> RunnerManager::matchSessionComplete(). if there are no jobs running,
>> checkTearDown() will run immediately. otherwise, it will wait until the jobs
>> are all done.
>>
> Oh right... :) In that case apart from not removing the checkTeardown call in reset I think the patch is good to go.

I mean removing the checkTeardown call in reset.

- Ryan